[utilities] make pattern match more accurate #15575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devopsdays-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
I tested this a on a few different strings and it worked as expected. I only tested on a modern macbook however, so I'm not sure how things would go on e.g. Linux. |
somatorio
approved these changes
Nov 11, 2025
mattstratton
approved these changes
Nov 11, 2025
Copilot finished reviewing on behalf of
mattstratton
November 11, 2025 15:11
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regex pattern matching bug in the change_sponsor_logo.sh script that was causing greedy/errant behavior when matching sponsor IDs in event files.
Key changes:
- Updated the
SPONSOR_REGEXpattern to properly match end-of-line by moving the$anchor outside the character class
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern matching in
change_sponsor_logo.shscript wasn't precise enough, resulting in errant (greedy) behaviour (example: #15572 (comment)).I think this is all we need to do to tighten it up. By moving the
$from the brackets and to the end of the regex, we will nab only the string literal, not any substrings.